From eb1a6d311a8b559800d16ead835d929b1a878375 Mon Sep 17 00:00:00 2001 From: shachar700 Date: Thu, 4 Dec 2025 23:34:36 +0200 Subject: [PATCH 1/2] fixed pokenav glow issue --- src/pokenav_menu_handler_gfx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/pokenav_menu_handler_gfx.c b/src/pokenav_menu_handler_gfx.c index ce17f33cfc..a86d0be080 100644 --- a/src/pokenav_menu_handler_gfx.c +++ b/src/pokenav_menu_handler_gfx.c @@ -1315,7 +1315,11 @@ static void SetupPokenavMenuScanlineEffects(void) SetGpuRegBits(REG_OFFSET_DISPCNT, DISPCNT_WIN0_ON); SetGpuRegBits(REG_OFFSET_WININ, WININ_WIN0_ALL); SetGpuRegBits(REG_OFFSET_WINOUT, WINOUT_WIN01_BG_ALL | WINOUT_WIN01_OBJ); +#ifdef BUGFIX + SetGpuReg(REG_OFFSET_WIN0V, DISPLAY_HEIGHT); +#else SetGpuRegBits(REG_OFFSET_WIN0V, DISPLAY_HEIGHT); +#endif ScanlineEffect_Stop(); SetMenuOptionGlow(); ScanlineEffect_SetParams(sPokenavMainMenuScanlineEffectParams); From 5240ee1515bbcfc54112fb5f9968edc1aae92056 Mon Sep 17 00:00:00 2001 From: shachar700 <48739719+shachar700@users.noreply.github.com> Date: Wed, 10 Dec 2025 13:51:47 +0200 Subject: [PATCH 2/2] Added comment --- src/pokenav_menu_handler_gfx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pokenav_menu_handler_gfx.c b/src/pokenav_menu_handler_gfx.c index a86d0be080..a4cdf48980 100644 --- a/src/pokenav_menu_handler_gfx.c +++ b/src/pokenav_menu_handler_gfx.c @@ -1316,6 +1316,9 @@ static void SetupPokenavMenuScanlineEffects(void) SetGpuRegBits(REG_OFFSET_WININ, WININ_WIN0_ALL); SetGpuRegBits(REG_OFFSET_WINOUT, WINOUT_WIN01_BG_ALL | WINOUT_WIN01_OBJ); #ifdef BUGFIX + // BUGFIX: Use full register write instead of |=. + // SetGpuRegBits left leftover window values from the Party screen, + // causing partial/missing glow highlights. SetGpuReg clears them fully. SetGpuReg(REG_OFFSET_WIN0V, DISPLAY_HEIGHT); #else SetGpuRegBits(REG_OFFSET_WIN0V, DISPLAY_HEIGHT);