From c27cc2ed705b93a0e649dc8d88ff0f95a6747494 Mon Sep 17 00:00:00 2001 From: Alex <93446519+AlexOn1ine@users.noreply.github.com> Date: Wed, 2 Jul 2025 09:16:05 +0200 Subject: [PATCH] Script clean up for Flame Burst and Costar (#7264) --- data/battle_scripts_1.s | 17 +++++------------ src/battle_message.c | 2 +- src/battle_script_commands.c | 3 +-- 3 files changed, 7 insertions(+), 15 deletions(-) diff --git a/data/battle_scripts_1.s b/data/battle_scripts_1.s index 150f2649ab..ffcd8b7d82 100644 --- a/data/battle_scripts_1.s +++ b/data/battle_scripts_1.s @@ -1573,16 +1573,12 @@ BattleScript_EffectAfterYou:: BattleScript_MoveEffectFlameBurst:: tryfaintmon BS_TARGET - copybyte sBATTLER, sSAVED_BATTLER printstring STRINGID_BURSTINGFLAMESHIT waitmessage B_WAIT_TIME_LONG - savetarget - copybyte gBattlerTarget, sSAVED_BATTLER orword gHitMarker, HITMARKER_IGNORE_SUBSTITUTE | HITMARKER_PASSIVE_DAMAGE - healthbarupdate BS_TARGET - datahpupdate BS_TARGET - tryfaintmon BS_TARGET - restoretarget + healthbarupdate BS_SCRIPTING + datahpupdate BS_SCRIPTING + tryfaintmon BS_SCRIPTING goto BattleScript_MoveEnd BattleScript_EffectPowerTrick:: @@ -7634,12 +7630,9 @@ BattleScript_SupremeOverlordActivates:: BattleScript_CostarActivates:: pause B_WAIT_TIME_SHORT - savetarget - copybyte gBattlerTarget, sBATTLER call BattleScript_AbilityPopUp printstring STRINGID_PKMNCOPIEDSTATCHANGES waitmessage B_WAIT_TIME_LONG - restoretarget end3 BattleScript_ZeroToHeroActivates:: @@ -8187,11 +8180,11 @@ BattleScript_FriskMsg:: BattleScript_FriskActivates:: saveattacker - savetarget + savetarget copybyte gBattlerAttacker, sBATTLER tryfriskmsg BS_SCRIPTING restoreattacker - restoretarget + restoretarget end3 BattleScript_ImposterActivates:: diff --git a/src/battle_message.c b/src/battle_message.c index 82dd9fe040..9082bbef6c 100644 --- a/src/battle_message.c +++ b/src/battle_message.c @@ -318,7 +318,7 @@ const u8 *const gBattleStringsTable[STRINGID_COUNT] = [STRINGID_PKMNENDUREDHIT] = COMPOUND_STRING("{B_DEF_NAME_WITH_PREFIX} endured the hit!"), [STRINGID_MAGNITUDESTRENGTH] = COMPOUND_STRING("Magnitude {B_BUFF1}!"), [STRINGID_PKMNCUTHPMAXEDATTACK] = COMPOUND_STRING("{B_ATK_NAME_WITH_PREFIX} cut its own HP and maximized its Attack!"), - [STRINGID_PKMNCOPIEDSTATCHANGES] = COMPOUND_STRING("{B_ATK_NAME_WITH_PREFIX} copied {B_DEF_NAME_WITH_PREFIX2}'s stat changes!"), + [STRINGID_PKMNCOPIEDSTATCHANGES] = COMPOUND_STRING("{B_ATK_NAME_WITH_PREFIX} copied {B_SCR_NAME_WITH_PREFIX2}'s stat changes!"), [STRINGID_PKMNGOTFREE] = COMPOUND_STRING("{B_ATK_NAME_WITH_PREFIX} got free of {B_DEF_NAME_WITH_PREFIX2}'s {B_BUFF1}!"), //not in gen 5+, generic rapid spin? [STRINGID_PKMNSHEDLEECHSEED] = COMPOUND_STRING("{B_ATK_NAME_WITH_PREFIX} shed Leech Seed!"), //not in gen 5+, generic rapid spin? [STRINGID_PKMNBLEWAWAYSPIKES] = COMPOUND_STRING("{B_ATK_NAME_WITH_PREFIX} blew away Spikes!"), //not in gen 5+, generic rapid spin? diff --git a/src/battle_script_commands.c b/src/battle_script_commands.c index 1a0e933383..f51561eab0 100644 --- a/src/battle_script_commands.c +++ b/src/battle_script_commands.c @@ -3712,8 +3712,7 @@ void SetMoveEffect(u32 battler, u32 effectBattler, bool32 primary, bool32 certai && !(gStatuses3[BATTLE_PARTNER(gBattlerTarget)] & STATUS3_SEMI_INVULNERABLE) && GetBattlerAbility(BATTLE_PARTNER(gBattlerTarget)) != ABILITY_MAGIC_GUARD) { - i = BATTLE_PARTNER(gBattlerTarget); - gBattleScripting.savedBattler = i; + gBattleScripting.battler = i = BATTLE_PARTNER(gBattlerTarget); gBattleStruct->moveDamage[i] = gBattleMons[i].maxHP / 16; if (gBattleStruct->moveDamage[i] == 0) gBattleStruct->moveDamage[i] = 1;