ghoulslash
326fb2605a
Some gActiveBattler Fixes ( #3259 )
...
* some gActiveBattler related fixes
* fix IsBattleSEPlaying gActiveBattler->battlerId
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-08-29 09:31:11 +02:00
voloved
2a2cd77cf4
Allow Cycling Through Balls in the Last Ball Used Menu ( #3039 )
2023-08-24 19:23:26 -04:00
Philipp AUER
905fc6fd4d
Fixed Metronome Item damage multiplier ( #3246 )
...
Co-authored-by: sbird <sbird@no.tld>
2023-08-23 19:23:00 -04:00
Eduardo Quezada
a6dbb68bac
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# data/battle_scripts_1.s
# src/battle_util.c
# src/battle_z_move.c
2023-08-17 13:42:09 -04:00
kittenchilly
dba28cf93f
Allow Z-Moves to be selected after Mega Evolution ( #3233 )
...
* Allow Z-Moves to be selected after Mega Evolution
* You cannot do Wish Mega Evolution at all if you hold a z crystal
* Rebase to master
2023-08-14 19:10:15 -04:00
Eduardo Quezada
952bacd858
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# .github/ISSUE_TEMPLATE/01_battle_engine_bugs.yaml
# .github/ISSUE_TEMPLATE/02_battle_ai_issues.yaml
# .github/ISSUE_TEMPLATE/04_other_errors.yaml
2023-08-11 17:50:28 -04:00
Eduardo Quezada D'Ottone
ada29313de
Fix for wild double battles with an in-game partner ( #3210 )
...
Co-authored-by: DizzyEggg <jajkodizzy@wp.pl>
2023-08-11 17:29:10 -04:00
Philipp AUER
59da940283
Refactor damage formula to match Gen5+ ( #3196 )
...
* [battle, damage] refactor damage formula to match gen5+
* [test] use exact values for dry skin, swarm tests
* fixup: assume stats for dry-skin, swarm tests
---------
Co-authored-by: sbird <sbird@no.tld>
2023-08-11 16:28:38 -04:00
Alex
8ee3a3c5bb
solve conflics
2023-08-07 14:25:30 +02:00
Eduardo Quezada
f94efa94e1
Merge branch 'RHH/master' into RHH/upcoming
2023-08-02 01:18:07 -04:00
Eduardo Quezada
87050d8c08
Fix Stamina/Wind Power/Electromorphosis/Rattled issues with targets ( #3143 )
2023-08-01 23:54:04 -04:00
DizzyEggg
5eec3b2fc3
fix various issues with primal weather blocking water/fire type moves ( #3138 )
...
* fix various issues with primal weather blocking water/fire type moves
* forgot to change return to effect=1
* fix bugs
2023-07-30 10:50:51 -04:00
Alex
5fa7a6d4c6
Skill Link Tests, Loaded Dice stuff
2023-07-28 13:20:06 +02:00
Alex
bca29d8586
Adds Mortal Spin and Population Bomb
2023-07-26 17:37:56 +02:00
DizzyEggg
a3d6e31227
Merge branch 'rattled' into stamina_fix
2023-07-26 09:36:46 +02:00
Eduardo Quezada
ad78dfcf68
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# src/battle_script_commands.c
# src/battle_util.c
2023-07-25 14:38:53 -04:00
Alex
da9b421ae1
Fix Ruin ability calcs ( #3171 )
2023-07-25 09:59:26 +02:00
ghoulslash
b5431898c2
RNG for Metronome, multi-hit moves, and Loaded Dice ( #3159 )
2023-07-23 08:15:14 -04:00
Martin Griffin
fc321965a9
RNG_HITS and RNG_LOADED_DICE
2023-07-23 10:24:58 +01:00
Eduardo Quezada
47cea526ec
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# src/battle_util.c
2023-07-19 23:22:07 -04:00
Alex
6b5d1e7577
Adds some gen9 moves ( #3147 )
...
* Adds some gen9 moves
* Fix Test + Tabs
* Collision Course boost changed to 1.3333
2023-07-19 13:25:20 +02:00
Eduardo Quezada D'Ottone
cf29c9eb69
Fixed enemy parties not reverting to their original form post-battle ( #3150 )
2023-07-19 08:46:57 +02:00
Eduardo Quezada D'Ottone
b08c8f85fc
Fixed Utility Umbrella damage calculations ( #2835 )
...
* Fixed Utility Umbrella holders not receiving regular damage when being hurt by what would've been weakened rain/sun attacks
* Fixed reading move incorrectly
* Tests: Sun, Rain, Utility Umbrella and Hydro Steam
* [STASH] Skeli changes, needs to remake tests
* Fixed tests
* Removed redundant tests
* Removed unused variable
* Removed Primal Todo tests
2023-07-18 09:22:05 +02:00
Eduardo Quezada D'Ottone
43ad1a4d3b
Unified multi-strike move flags ( #3126 )
...
* Unified twoStrikes and threeStrikes flags into strikeCount
* Decreased strikeCount max from 255 to 15.
2023-07-18 09:07:14 +02:00
Alex
38655b9d1f
Fix gem boost on multi hit moves and config for gem param ( #3144 )
2023-07-18 06:11:54 +01:00
DizzyEggg
04feba8314
test for electromorphosis, small fix for wind power
2023-07-17 16:30:59 +02:00
Alex
330e20b9e9
Fix Protosynthesis and Quark Drive boosts ( #3139 )
...
* Fix Protosynthesis and Quark Drive boosts
* Added Tests + fix newly introduced bug in the PR
Add unintentionally deletet break
new line
2023-07-17 11:10:13 +02:00
DizzyEggg
1f1d24b3e4
Fix Primal Reversion not activating when switching in after fainting ( #3141 )
...
* Fixed Primal Reversion not activating when switching in after a fainting
* add tests for primal reversion
Co-authored-by: Eduardo Quezada <eduardo602002@gmail.com>
2023-07-16 12:26:54 +01:00
Martin Griffin
17f8f50a59
Merge remote-tracking branch 'rhh/master' into upcoming
2023-07-16 07:46:34 +01:00
Martin Griffin
58ede15263
Fix Roullout Fury Cutter AI power calc ( #3110 )
2023-07-16 06:45:35 +01:00
DizzyEggg
2a249654e7
fix mirror move/metronome powder/multi hit moves & tests
2023-07-15 14:00:55 +02:00
DizzyEggg
0c0b841a80
Remove debug item effect override ( #3106 )
2023-07-13 18:47:01 -04:00
sbird
6482279fa3
[battle, math] refactor damage calculation to use proper fp type and inlined multiplication
2023-07-07 18:51:23 +02:00
DizzyEggg
9a09f1e3b9
Fix Roullout Fury Cutter AI power calc
2023-07-06 13:41:16 +02:00
ghoulslash
cc3a6d4d94
make special case ABILITYEFFECT_xx ids their own caseId switch cases to fix potential overlap with ability IDs 0xFF etc ( #3083 )
...
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-07-03 10:03:50 +02:00
Eduardo Quezada D'Ottone
1fa9a05470
Convert move flags and bans into GCC bitfields ( #2952 )
...
* Slicing moves to new bitfield
* Wind moves to new bitfield
* Two-strike moves to new bitfield
* Forgot to add flagTwoStrikes to battle_moves.h
* Removed "flag" from field names
* FLAG_HIT_IN_SUBSTITUTE and FLAG_THAW_USER
* Airborne moves
* FLAG_POWDER, FLAG_TARGET_ABILITY_IGNORED and FLAG_DANCE
* FLAG_BALLISTIC and FLAG_PROTECTION_MOVE
* Fixed missing uses of MOVE_UNAVAILABLE in battle_ai_util.c
* FLAG_SOUND
* FLAG_DMG_UNDERGROUND and FLAG_DMG_UNDERWATER
* FLAG_DMG_MINIMIZE
* Cleanup
* FLAG_STAT_STAGES_IGNORED
* Updated Pollen Puff's ballistic flag
* FLAG_STRONG_JAW_BOOST and FLAG_MEGA_LAUNCHER_BOOST
* thaw
* FLAG_THREE_STRIKES
* FLAG_IRON_FIST_BOOST
* FLAG_RECKLESS_BOOST
* FLAG_HIGH_CRIT
* Removed empty flags
* Moves that fail when called by Me First + added missing Shell Trap
* Moves that fail when Gravity is active
* Better names for banned fields
* Moves that fail when called by Instruct
* Cleanup
* Contact Moves + Fixed Wandering Spirit skipping contact checks
* Inverted FLAG_PROTECT_AFFECTED so that there's a flag for moves that SKIP protect.
* Simplified B_MOVE_FLAGS configs
* FORBIDDEN_METRONOME
* Renamed hitsPastSubstitute to ignoresSubstitute
* FORBIDDEN_PARENTAL_BOND
* Struggle uncallable by Metronome
* FORBIDDEN_MIMIC
* FLAG_KINGS_ROCK_AFFECTED
* Made a single config for move flags
* Macro for checking move flags
* FLAG_MAGIC_COAT_AFFECTED
* Fixed HasMagicCoatAffectedMove
* FLAG_SNATCH_AFFECTED
* Removed unused EFFECT_FLINCH_MINIMIZE_HIT
* Fixed Stench/King's Rock interaction
* Removed sMovesNotAffectedByStench in favor of checking move effects
* Removed EFFECT_TWISTER, which was a repeat of EFFECT_FLINCH_HIT
* Changed Gen2 configs to less than Gen 3
* FORBIDDEN_SLEEP_TALK
* Cleanup
* Inverted FLAG_MIRROR_MOVE_AFFECTED
* FLAG_SHEER_FORCE_BOOST
* Ordered
* FORBIDDEN_ASSIST and FORBIDDEN_COPYCAT
* Removed TestMoveFlags and TestMoveFlagsInMoveset + flags field
* Fixed Triple Arrows test
2023-07-03 10:01:59 +02:00
Eduardo Quezada
ca1d9f5393
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# include/battle_util.h
2023-06-21 15:01:14 -04:00
ghoulslash
7371a9e401
Add many gen 8 move animations ( #2861 )
...
* port many gen8 and 9 move anims from cfru
* fix thunder cage, shell smash, shelter anims. update anim credits
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-06-21 13:19:54 -04:00
Pawkkie
62ae3b1df1
Fix bug due to variable overflow when AI chooses new Pokemon to send out ( #3068 )
2023-06-21 12:59:30 -04:00
LOuroboros
2bf88502a7
More corrections
2023-06-19 04:18:53 -03:00
LOuroboros
9896f20eb8
Applied fixes and corrections (Jun 2023)
2023-06-15 09:22:26 -03:00
LOuroboros
313f522622
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into gen_9_move_effects_batch2
2023-06-13 05:44:37 -03:00
BuffelSaft
2e08277a4e
Fixes Triple Kick effect and Z move damage calc ( #2983 )
2023-05-31 22:25:16 +12:00
Alex
5a384f9090
Fixes Triple Kick effect and Z move damage calc
...
minor correction to the z-move fix
Add comment to EFFECT_TRIPLE_KICK
2023-05-29 15:28:40 +02:00
Eduardo Quezada D'Ottone
d0e6ea7612
Optimized battle gender checks ( #3020 )
...
* Optimized battle gender checks
* Apply suggestions from code review
Co-authored-by: AgustinGDLV <103095241+AgustinGDLV@users.noreply.github.com>
---------
Co-authored-by: AgustinGDLV <103095241+AgustinGDLV@users.noreply.github.com>
2023-05-27 17:23:02 -04:00
AgustinGDLV
5a8715e608
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into castform_fix
2023-05-23 16:10:44 -07:00
AgustinGDLV
6a92caa9fb
removed old B_WEATHER_FORMS use, tests now have assumptions for config
2023-05-23 16:10:26 -07:00
AgustinGDLV
d4c7e5e559
changed B_WEATHER_FORM preproc to affect tables instead of function
2023-05-23 14:03:38 -07:00
Alex
109b4c4f6c
Small clean up: EndTurnTerrain, BattleScript_GrassyTerrainHeals ( #3018 )
...
remove leftover
2023-05-20 15:58:55 -04:00
Alex
a0881b8e8d
Terrains freeze the game after player mon faints ( #3016 )
2023-05-20 11:10:45 -04:00