DizzyEggg
0c523f9518
Fix Magic bounce powder moves against grass types ( #2633 )
...
* Fix Magic bounce powder moves against grass types
2023-02-17 13:55:51 +00:00
DizzyEggg
56c9564e7a
8th gen Howl's effect ( #2700 )
...
* Howl gen8 effect
2023-02-17 10:28:46 +00:00
DizzyEggg
d637ee3b13
Fix After You for gen8 ( #2646 )
...
Fix After You
2023-02-16 20:59:36 +00:00
Eduardo Quezada
f4f8ab6ee9
Merge branch 'RHH/upcoming' into RHH/pr/feature/formBattleChange
2023-02-16 17:06:49 -03:00
Eduardo Quezada
bd54990333
Review changes
2023-02-15 13:56:11 -03:00
ghoulslash
908b509401
Fix Round's Base Power calc, Add Turn order effects ( #2602 )
...
* fix round base power calc, add turn order change
* remove unused callnative cmd
* fix round turn order update
* fix moveTarget getting set incorrectly in HandleAction_UseMove. also redirection doesn't affect MOVE_TARGET_ALL_BATTLERS
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-02-14 16:49:50 +01:00
Eduardo Quezada
96865f66af
Updated term to modernFatefulEncounter
2023-02-11 22:36:42 -03:00
Eduardo Quezada
6da5e0a280
Rename eventLegal to fatefulEncounter
2023-02-11 17:13:53 -03:00
ghoulslash
7e9d40d401
Merge pull request #2645 from DizzyEggg/damp_aftermath
...
Damp shows ability pop-up when reacting with Aftermath
2023-02-07 10:18:23 -05:00
DizzyEggg
f762ed728d
remove pointless timers from disable struct
2023-02-07 15:10:20 +01:00
DizzyEggg
0dc5e1e685
aftermath damp pop-ups and string
2023-02-07 13:01:56 +01:00
Eduardo Quezada
101ea6522d
Merge branch 'RHH/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# src/battle_util.c
2023-02-02 17:56:13 -03:00
LOuroboros
4b5a6e2328
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into gen_9_move_effects_batch1
2023-02-01 20:18:56 -03:00
Philipp AUER
8983739267
Merge pull request #2564 from mrgriffin/rhh-battle-tests
...
Battle Tests
2023-02-01 22:18:17 +01:00
ghoulslash
feb4bfee42
fix toxic debris side status check
2023-01-28 13:56:09 -05:00
Martin Griffin
cba4b78df6
Move-based mega evolution message for NPCs/recorded battles
2023-01-28 00:16:24 +00:00
Eduardo Quezada D'Ottone
53e41a2b3d
Merge pull request #2605 from mrgriffin/rhh-battle-tests-fixes
...
Rhh battle tests fixes
2023-01-27 19:24:13 -03:00
Martin Griffin
6a403ab45c
Pastel Veil grants immunity to poison
2023-01-27 00:57:24 +00:00
Martin Griffin
3647825a30
Fix Poison Point
...
It incorrectly activated only if the Pokémon with Poison Point could be
poisoned by the attacker.
2023-01-27 00:57:24 +00:00
Martin Griffin
a13ffdbfba
U-turn does not switch the user out if Emergency Exit activates
2023-01-27 00:57:22 +00:00
Eduardo Quezada
3288309c43
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# src/battle_script_commands.c
2023-01-25 19:57:19 -03:00
Eduardo Quezada
a044774896
Added Gen9 item data and fixed Punching Glove's effect
2023-01-24 16:47:54 -03:00
ghoulslash
321634ed3b
Silk Trap Effect ( #2512 )
...
* add silk trap effect, analog of obstruct
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-01-23 16:42:47 -03:00
ghoulslash
8cc923ebcc
parentheses around random & 1
2023-01-23 09:42:04 -05:00
ghoulslash
e93d22c0f1
optimize IsMoveMakingContact
2023-01-23 09:37:05 -05:00
ghoulslash
125e73dd07
loaded dice fix
2023-01-23 09:36:17 -05:00
ghoulslash
f97ec1975a
merge w upcoming
2023-01-23 09:24:03 -05:00
ghoulslash
428ea97028
IsBattlerAlive instead of hp check
2023-01-21 12:11:12 -05:00
ghoulslash
a044084182
Remove redundant IsBattlerAlive checks from ITEMEFFECT_ORBS
2023-01-21 11:11:50 -05:00
ghoulslash
9e6c5725d0
add hp check to ITEMEFFECT_ORBS
2023-01-21 08:55:20 -05:00
Eduardo Quezada
749225ace1
Matching merge from upstream pret
...
# Conflicts:
# graphics/interface/menu_info.png
# include/pokemon.h
# src/battle_ai_switch_items.c
# src/battle_anim_mons.c
# src/battle_anim_water.c
# src/battle_controller_opponent.c
# src/battle_gfx_sfx_util.c
# src/battle_main.c
# src/battle_pike.c
# src/battle_script_commands.c
# src/data/pokemon/species_info.h
# src/pokemon.c
# src/pokemon_summary_screen.c
2023-01-20 12:31:54 -03:00
Eduardo Quezada
ac4825ad28
Merge branch 'RHH/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# src/battle_util.c
2023-01-13 11:50:47 -03:00
Bassoonian
3b4cba9b51
Apply suggestions from code review
...
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
2023-01-11 14:11:47 +01:00
Bassoonian
333917941b
Add PLA+ obedience mechanics (with config)
2023-01-11 08:15:57 +01:00
LOuroboros
bdcc84f019
Updated the implementation
2023-01-09 15:18:22 -03:00
LOuroboros
dccceb9689
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into iceFaceRedux
2023-01-09 14:59:41 -03:00
ghoulslash
cc7c546011
Merge pull request #2473 from LOuroboros/mimicry
...
Reimplemented Mimicry
2023-01-09 12:54:44 -05:00
LOuroboros
ba21ffb3f2
Oopsie. Protosynthesis is NOT a terrain ability
2023-01-09 14:37:18 -03:00
LOuroboros
620a6a5e90
Extra review changes
...
-Foolproofed the ability checks in ABILITYEFFECT_ON_WEATHER and ABILITYEFFECT_ON_TERRAIN
-Made BattleScript_OverworldWeatherStarts and BattleScript_OverworldTerrain call the battle scripts that handle weather form changes, weather abilities, terrain seeds and terrain abilities.
-Consequentially, I removed the activation for weather and terrain abilities that I added to TryDoEventsBeforeFirstTurn, and the activation of Protosynthesis in ABILITYEFFECT_ON_SWITCHIN.
-Added a weatherAbilityDone to prevent abilities that lack self-checks like Protosynthesis from getting stuck in a loop.
-Removed now pointless ABILITYEFFECT_WEATHER_FORM. I think Duke/Sneed69 added it to fix Castform's form change, but it no longer serves a purpose.
2023-01-09 14:22:14 -03:00
LOuroboros
91b2e1bb50
More review changes and added lackings
...
-Removed unnecessary special handling of terrain-inducing overworld weather states from ChangeTypeBasedOnTerrain.
-Mimicry now activates normally for terrain-inducing overworld weather states.
-Weather abilities now activate normally when switchineffects is called, and at the beginning of a battle.
-Terrain abilities now activate normally at the beginning of a battle.
2023-01-09 07:55:55 -03:00
LOuroboros
c32f584940
Applied review changes
2023-01-08 19:50:27 -03:00
ghoulslash
1d2cb49bc6
Merge pull request #2542 from AsparagusEduardo/RHH/pr/config/multiTargetDmg
...
Config to restore Gen 3's damage reduction to multi target moves
2023-01-04 09:18:39 -05:00
LOuroboros
f1ca254c28
Updated the Mimicry reimplementation
...
Mimicry is now a proud member of ABILITYEFFECT_ON_TERRAIN.
Misc. changes:
-Ditched the dependency on and usage of gBattlerAttacker for the effects inside ABILITYEFFECT_ON_WEATHER and ABILITYEFFECT_ON_TERRAIN.
-Made Cmd_switchineffects activate ABILITYEFFECT_ON_TERRAIN to take into account overworld weather-induced field terrains.
-Updated the text strings printed by the battle scripts inside the aforementioned AbilityBattleEffects caseIDs.
-Removed constant label of unused VARIOUS_TRY_TO_APPLY_MIMICRY which I forgot about.
-Updated ChangeTypeBasedOnTerrain, partly as a result of the aforementioned changes but also for optimization purposes.
-There was never a reason to establish an empty scope, or to use GET_MOVE_TYPE and the variables that complemented it.
-Removed case ABILITY_QUARK_DRIVE from AbilityBattleEffects' case ABILITYEFFECT_ON_SWITCHIN.
2023-01-03 02:27:41 -03:00
LOuroboros
d0f5653f5e
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into mimicry
2023-01-02 19:00:41 -03:00
Eduardo Quezada
a23501a4a3
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# src/battle_script_commands.c
2023-01-02 18:54:57 -03:00
LOuroboros
0a00942a26
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into gen_9_move_effects_batch1
2023-01-02 16:00:13 -03:00
LOuroboros
13d8c0d167
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into dev_gen9_abilities
2023-01-02 14:34:24 -03:00
LOuroboros
ca32d43433
Streamlined ability-on-weather changes
...
Also renamed activateweatherabilities and activateterrainabilities.
2023-01-02 14:32:56 -03:00
Eduardo Quezada
16e8a5dd7f
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# include/battle_util.h
2023-01-01 16:02:40 -03:00
LOuroboros
f2e63a2e41
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into iceFaceRedux
2022-12-31 03:33:42 -03:00