5260 Commits

Author SHA1 Message Date
Estellar
1de27646d2
Remove magic numbers in slot_machine.c (#2195) 2025-10-28 09:19:12 +00:00
DavidJCobb
7fd0029ed7
Add typedefs for MAPSEC and METLOC values (#2183)
Added typedefs: mapsec_t, metloc_t, and variants for MAPSEC and METLOC values. There are some rough edges that could do with smoothing out, but for now, this gets us close to ideal with a ROM that compares equal.

Per feedback, all typedefs to mention the underlying type within the typedef name. The documentation comments reflect and explain the naming convention.

Updated comments to reflect the fact that we're no longer using SET8 for a Pokemon's met locations, in favor of a new macro (added by this PR) that adjusts to match the width of whatever is being set.
2025-10-19 17:37:13 +01:00
Estellar
0965dffe70
Use TaskFunc wherever posible (#2188) 2025-10-18 17:53:50 +01:00
Estellar
f4f7c38255
Use MainCallback wherever posible (#2184) 2025-10-14 09:41:27 +01:00
FosterProgramming
d05742ca05
Fix include order in wild_encounter.c (#2185) 2025-10-14 09:36:32 +01:00
FosterProgramming
9c8cfe3b75
Fix include order in src/clock.c to be alphabetical (#2181) 2025-09-13 17:49:36 +01:00
FosterProgramming
276275f837
Fix 3 spaces tabs in field_message_box.c (#2179) 2025-09-10 06:44:14 +01:00
Alex
208f97e1e3
Rename passive damage hitmarker (#2174) 2025-08-21 13:43:19 +01:00
GriffinR
92f7727a60
Merge pull request #2107 from AsparagusEduardo/pret/pr/simpleMultiBattleFix
Simplified Multi Battle bugfix, removing duplicate code
2025-08-14 15:09:42 -04:00
Josh
0dfec24967
Allow names for voicegroups and use a macro for use with drumsets (#2149)
mid2agb has been modified to allow more than just numbers when naming voicegroups and voicegroups have been renamed to match. A "voice_group" macro has been set up with a optional parameter for the starting note will shift the offset by the specified amount * 0xC which is the length of 1 voice in a voicegroup. All drumset voicegroups have a "starting_note" of 36.
2025-07-30 19:43:08 +01:00
cawtds
5da5cb4c8c document shop menu palette 2025-07-26 20:19:45 +02:00
GriffinR
6f8a1bbdb8
Add pack/unpack for data masks (#2163) 2025-07-23 09:28:34 +01:00
Raymond Dodge
80b9c23d0a
Fix RL compressed data alignment
`RLUnComp`, like `LZ77UnComp`, expects the source data to be word-aligned.
So, to mirror how lz-compressed data is defined as `u32[]` to enforce
word-alignment, this changes rl-compressed data to be defined as `u32[]`
to enforce word-alignment.
2025-07-06 13:49:47 -04:00
GriffinR
aac44d0f91
Merge pull request #2073 from AsparagusEduardo/_pret/pr/pyramidLocation
Improve Pyramid location documentaion
2025-06-30 13:30:14 -04:00
GriffinR
0c7c81e02f
Merge branch 'master' into _pret/pr/pyramidLocation 2025-06-30 11:51:45 -04:00
GriffinR
44c3069895 Add explicit defaults for MAPSEC data 2025-06-26 16:26:59 -04:00
GriffinR
670d3a6c9f
Merge pull request #2152 from GriffinRichards/mapsec-data
Relax MAPSEC region map data requirements
2025-06-25 22:05:35 -04:00
GriffinR
2a7a4f1e76
Merge pull request #2127 from AsparagusEduardo/_pret/maxLinkPlayers
Fix other missing instances of MAX_LINK_PLAYERS
2025-06-25 22:05:13 -04:00
DizzyEggg
9df5ab16e8
Ensure sMonMarkings_Gfx alignment (#2158) 2025-06-25 19:41:23 +01:00
DizzyEggg
64a6e8817c
Fix sGpuRegBuffer potential alignment issues (#2157) 2025-06-25 17:54:13 +01:00
DizzyEggg
e1b83d6056
Match graphics declarations with externs (#2089) 2025-06-23 20:31:18 +01:00
GriffinR
4ce83c7d96
Merge pull request #2104 from GriffinRichards/fix-collision-comparison
Fix collision comparison in PlayerNotOnBikeMoving
2025-06-22 20:05:30 -04:00
DizzyEggg
53f8ae11ff
Move gTradePlatform_Tilemap to header (#2088) 2025-06-22 19:48:37 -04:00
psf
75fe3e7da6
Fixed typo in sMoveRelearnerMenuState (#2155) 2025-06-17 15:38:33 +01:00
GriffinR
bfa3e4a07b
Merge pull request #2145 from abaresk/remove-berryfix
Remove berry yield bug fix
2025-06-15 00:41:33 -04:00
DizzyEggg
1cc4321a42
Fix AnimItemSteal_Step3 and AnimKnockOffOpponentsItem matches 2025-06-13 16:45:24 +02:00
GriffinR
50d81616cd Relax MAPSEC region map data requirements 2025-06-10 13:05:03 -04:00
ghoulslash
96844bd3bb fix sprite count in RepeatBallOpenParticleAnimation 2025-06-09 16:19:25 -04:00
cawtds
b36a78ed47 replace magic numbers with enums 2025-06-02 22:55:41 +02:00
cawtds
0fc900514b sync list menu functions with firered 2025-06-02 22:51:26 +02:00
GriffinR
0c32d840fa
Merge pull request #2141 from pret/porymap-6
Update for Porymap 6
2025-05-27 10:53:17 -04:00
GriffinR
fba096a500 Remove map_group_count.h 2025-05-22 13:59:23 -04:00
Alex
b31a73f990
Rename ItemId_GetX to GetItemX (#2116) 2025-05-22 13:27:52 +01:00
Abaresk
bef343cefa Remove berry yield bug fix 2025-05-21 16:11:18 -04:00
Kurausukun
bd0a02c456
Correct C23 Checks (#2144) 2025-05-19 15:43:06 +01:00
Bassoonian
59d315734d
Update header files to match source files (#2143) 2025-05-19 09:18:04 +01:00
Kurausukun
e1e7d1cf35
Fixes for C23 Support (#2138)
* fixes for c23 support
* include global.h in m4a.c & remove <string.h> include
2025-05-19 09:11:59 +01:00
Bassoonian
16357c7e29
Streamline pointer notation (#2139) 2025-05-16 12:04:44 +01:00
GriffinR
929bc8b990 Merge branch 'master' of https://github.com/pret/pokeemerald into porymap-6 2025-05-14 11:50:11 -04:00
Martin Griffin
484c41c49d Remove files that should not have been committed 2025-05-13 14:56:31 +01:00
Alex
51b000860b
Add BattlerId enum and document (#2135) 2025-05-11 07:36:39 +01:00
Alex
baf5be2035
Replace: moveId -> move, moveIdx -> moveIndex (#2134) 2025-05-09 16:33:23 +01:00
Alex
2044bea883
Rename battlerId to battler for consistency (#2126) 2025-05-09 12:43:23 +01:00
Eduardo Quezada
15e39339b9 InitSpritePosToAnimAttacker documentation 2025-05-06 15:11:38 -04:00
GriffinR
c39ef1a030
Merge pull request #2125 from DavidJCobb/battle-link-re
Battle link reverse-engineering
2025-05-05 18:17:28 -04:00
DavidJCobb
0f17e70371 Shorter names for engine/controller communication enum members 2025-05-02 00:01:15 -04:00
DavidJCobb
d83b0671f7 Battle anims, ice: ARRAY_COUNT works if used with a cast 2025-05-01 23:49:05 -04:00
DavidJCobb
35b33a46e9 Identified task and sprite fields related to battle weather animations
Named task and sprite fields related to the animations for Hail, Rain Dance, and Sandstorm.
2025-04-28 05:39:52 -04:00
Eduardo Quezada
56bd65eb9d Fix other missing instances of MAX_LINK_PLAYERS 2025-04-27 22:28:26 -04:00
DavidJCobb
2864408060 Tweaks to documentation comments 2025-04-26 11:40:14 -04:00