Cloyir/pokeemmo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2215 from shachar700/pokenav-glow

Browse Source 
Fixed pokenav glow issue
This commit is contained in:
Martin Griffin 2025-12-26 08:58:16 +00:00 committed by GitHub
commit b0d2642e56
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/pokenav_menu_handler_gfx.c
View File

@ -1315,7 +1315,14 @@ static void SetupPokenavMenuScanlineEffects(void)
SetGpuRegBits(REG_OFFSET_DISPCNT, DISPCNT_WIN0_ON); SetGpuRegBits(REG_OFFSET_DISPCNT, DISPCNT_WIN0_ON);
SetGpuRegBits(REG_OFFSET_WININ, WININ_WIN0_ALL); SetGpuRegBits(REG_OFFSET_WININ, WININ_WIN0_ALL);
SetGpuRegBits(REG_OFFSET_WINOUT, WINOUT_WIN01_BG_ALL | WINOUT_WIN01_OBJ); SetGpuRegBits(REG_OFFSET_WINOUT, WINOUT_WIN01_BG_ALL | WINOUT_WIN01_OBJ);
#ifdef BUGFIX
// BUGFIX: Use full register write instead of |=.
// SetGpuRegBits left leftover window values from the Party screen,
// causing partial/missing glow highlights. SetGpuReg clears them fully.
SetGpuReg(REG_OFFSET_WIN0V, DISPLAY_HEIGHT);
#else
SetGpuRegBits(REG_OFFSET_WIN0V, DISPLAY_HEIGHT); SetGpuRegBits(REG_OFFSET_WIN0V, DISPLAY_HEIGHT);
#endif
ScanlineEffect_Stop(); ScanlineEffect_Stop();
SetMenuOptionGlow(); SetMenuOptionGlow();
ScanlineEffect_SetParams(sPokenavMainMenuScanlineEffectParams); ScanlineEffect_SetParams(sPokenavMainMenuScanlineEffectParams);