Alex
da9943d3b8
Clean up array access by using index instead of dereferencing the value ( #6057 )
2025-01-20 16:44:22 +01:00
hedara90
7c6c9120ea
Ewram and unused function cleanup sweep ( #6019 )
...
Co-authored-by: Hedara <hedara90@gmail.com>
2025-01-15 14:07:12 +01:00
hedara90
e4c81ba6e0
Removed all instances of gBitTable[x] ( #5123 )
...
* Replaced all the gBitTable[X] usages with 1 << X, and cleaned up script output
* Fixed failed merge in online viewer
---------
Co-authored-by: Hedara <hedara90@gmail.com>
2024-08-17 10:28:09 -05:00
DizzyEggg
26ef19d6c0
Fix wrong palette in palyer backsprite in recorded battle ( #4875 )
2024-06-27 11:33:28 +02:00
Frank DeBlasio
7f50c0b9c3
Simplify gTrainerSprites ( #4140 )
...
* Simplified y_offset equations
* Removed trainer pic animation from gTrainerSprites
* Used metaprogram to simplify trainer sprites without mugshots
* Incorporated comments
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2024-02-06 22:24:36 +01:00
Frank DeBlasio
5cdee87489
Refactor Trainer sprites ( #3597 )
...
* Added TrainerSprite struct with coordinates
* Added .frontPic to struct
* Added .palette to TrainerSprite struct
* Added .animation to the struct
* Added define for sprite size
* Condensed animations since they were all the same
* Improved TRAINER_SPRITE/PAL defines
* Simplified seemingly unused .y_offset and TRAINER_PIC_SIZE values
* Condensed TRAINER_SPRITE and TRAINER_PAL into TRAINER_PIC
* Renamed .size to .y_offset since that what it appears to actually be
* Moved y_offset into TRAINER_PIC
* Moved animation inside of TRAINER_PIC
* Added array number to preproc
* Removed trailing spaces
* Added sprite/palette files to preproc
* Revert adding sprites to preproc as it fails agbcc
This reverts commit dce57f8d1bfab70b4c6630a9c4e5b43495891459.
* Added backsprite struct
* Added animations to backsprite struct
* Changed TRAINER_PIC to TRAINER_SPRITE
* Added animation to backsprite preproc
* Added .backPic to struct
* Moved array number into backsprite preproc
* Removed definitions for trainer sprites
* Hardcoded sAnims_Trainer into struct since every sprite uses it
* Fixed TRAINER_SPRITE arguments
2023-12-20 23:14:33 +01:00
DizzyEggg
be5683e899
AI battle tests + AI logic fixes ( #3361 )
2023-10-04 18:53:29 +01:00
DizzyEggg
2fcb9bbc9b
Wild battle tests + tests for exp points ( #3342 )
...
* Add WIld Battles to test runner + exp tests
2023-09-27 08:35:05 +01:00
DizzyEggg
c29f8259f6
remove gActiveBattler entirely
2023-08-30 12:46:22 +02:00
DizzyEggg
4683783a92
remove active battler from other files
2023-08-30 10:18:31 +02:00
DizzyEggg
156aa59f18
start removing gActiveBattler in controller emitters
2023-08-29 15:21:31 +02:00
DizzyEggg
9cf5376c96
use GetBattlerParty in LoadMonSprite
2023-08-21 09:43:01 +02:00
DizzyEggg
ce18df46e6
replace global usage of gActiveBattler in controller files
2023-08-07 12:51:58 +02:00
DizzyEggg
b8ba6139cb
health bar update
2023-08-07 10:29:02 +02:00
DizzyEggg
546b0c7e97
handle move anim
2023-08-07 09:26:03 +02:00
DizzyEggg
e8d6c99e6d
more controllers work
2023-08-07 01:05:09 +02:00
DizzyEggg
ef8024d8c5
draw trainer pic
2023-08-06 21:50:59 +02:00
DizzyEggg
a9483c361b
trainer intro ball throw
2023-08-06 12:41:36 +02:00
DizzyEggg
ffb0e20049
hide show party status summary
2023-08-05 23:27:56 +02:00
DizzyEggg
18db0cb3b7
controller string
2023-08-05 22:41:13 +02:00
DizzyEggg
f9e131b6ac
fix recorded, exp update the same for player partner
2023-08-05 21:34:17 +02:00
DizzyEggg
0b4c1aa275
more work on controllers
2023-08-05 20:42:19 +02:00
DizzyEggg
1793b9e1da
more controller functions
2023-08-05 14:11:25 +02:00
DizzyEggg
a505cd7fb9
simplify the get mon set mon data functions more
2023-08-05 12:53:14 +02:00
DizzyEggg
cbebdf044a
handle se, bgm and fainting cry
2023-08-05 12:13:50 +02:00
DizzyEggg
c4bfe40da6
remove empty controller functions
2023-08-05 11:39:42 +02:00
DizzyEggg
c72bb27325
faint animation
2023-08-04 22:15:39 +02:00
DizzyEggg
7360a4a18a
up to return mon to ball
2023-08-04 17:29:29 +02:00
DizzyEggg
7ba8a0216f
more work on controllers
2023-08-04 13:42:40 +02:00
DizzyEggg
cc30d2fb53
start removing duplicate controller functions
2023-08-04 12:10:38 +02:00
Eduardo Quezada D'Ottone
81e59ace25
Cleaned up remaining Castform hack stuff ( #3063 )
...
* Removed gCastformFrontSpriteCoords
* Removed sCastformElevations and IsCastformForm
* Removed sCastformBackSpriteYCoords and castformPalette in BattleStruct
* Scrubbed unused BS commands
* Removed B_ANIM_CASTFORM_CHANGE and BattleForm constants
* Removed redundant function in Pokémon Debug menu
* Removed handling in animation scripts
* Removed gBattleMonForms
* Reduced MAX_MON_PIC_FRAMES to 2
* Removed Castform/Cherrim makefile stuff
* Fixed weather form change tests not checking species.
* Fixed Castform palettes after Lunos' PR
2023-06-30 09:58:07 +02:00
Martin Griffin
9cd13cc520
Fix USE_ITEM explicit targets
2023-05-07 07:50:41 +01:00
Eduardo Quezada D'Ottone
42445512ad
Battle Item Tests + critical fixes + new test macro ( #2940 )
2023-05-06 20:43:32 -04:00
Ultimate_Bob
32e63d8cc7
Don't copy opponent personality when swapping mon sprite during Mega Evolution ( #2852 )
...
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-04-30 21:15:03 -04:00
CallmeEchoo
a2809acfd1
fix gChosenMovePos not being assigned correctly for battle items
...
thanks griffin <3
Co-Authored-By: Martin Griffin <838573+mrgriffin@users.noreply.github.com>
2023-04-26 01:02:47 +02:00
Martin Griffin
c81a985b5b
Fix USE_ITEM explicit targets
2023-04-20 21:45:16 +01:00
AgustinGDLV
2eabcea86e
Battle Item Refactor ( #2902 )
...
* items that can be used in battle now use battlescripts
* removed ExecuteTableBasedItemEffect_
* taught AI how to use items, removed AI_itemtype/flag
* X-Items store stages raised in holdEffectParam
* USE_ITEM in tests
2023-04-14 19:25:50 +01:00
AgustinGDLV
86242c1c70
MOVE_REVIVAL_BLESSING Effect ( #2883 )
...
* implemented Revival Blessing
2023-04-12 01:14:25 +01:00
Martin Griffin
f1b9872bf0
Test moves, items, and abilities in battle
...
Thank you to SBird for providing mgba-rom-test binaries and Spikes/Toxic
Spikes tests!
Co-authored-by: sbird <sbird@no.tld>
2023-02-01 13:53:57 +00:00
Eduardo Quezada
749225ace1
Matching merge from upstream pret
...
# Conflicts:
# graphics/interface/menu_info.png
# include/pokemon.h
# src/battle_ai_switch_items.c
# src/battle_anim_mons.c
# src/battle_anim_water.c
# src/battle_controller_opponent.c
# src/battle_gfx_sfx_util.c
# src/battle_main.c
# src/battle_pike.c
# src/battle_script_commands.c
# src/data/pokemon/species_info.h
# src/pokemon.c
# src/pokemon_summary_screen.c
2023-01-20 12:31:54 -03:00
GriffinR
0cc10a1ada
Merge branch 'master' of https://github.com/pret/pokeemerald into ui-standardize
2023-01-18 11:07:12 -05:00
Bassoonian
333917941b
Add PLA+ obedience mechanics (with config)
2023-01-11 08:15:57 +01:00
Eduardo Quezada
5403cd036e
Merge remote-tracking branch 'pret/master' into RHH/pr/pretMerge_20220902
...
# Conflicts:
# include/battle.h
# include/battle_controllers.h
# src/battle_ai_script_commands.c
# src/battle_ai_switch_items.c
# src/battle_controller_opponent.c
# src/battle_controller_player.c
# src/battle_controllers.c
# src/battle_main.c
# src/battle_message.c
# src/battle_script_commands.c
# src/battle_util.c
2022-09-02 23:24:08 -04:00
Eduardo Quezada
15d611ba65
Usage of BATTLE_PARTNER
2022-08-27 01:26:13 -04:00
DizzyEggg
1b9c2816c2
fix updatehptextinhealthbox arguments
2022-08-25 17:37:47 +02:00
Eduardo Quezada
afcc1178b2
Merge remote-tracking branch 'pret/master' into MergedBranchUltimate
...
# Conflicts:
# data/battle_ai_scripts.s
# data/battle_scripts_1.s
# include/battle_controllers.h
# include/battle_script_commands.h
# include/battle_util.h
# include/constants/battle_script_commands.h
# include/constants/global.h
# include/decompress.h
# src/battle_anim_effects_1.c
# src/battle_anim_normal.c
# src/battle_anim_poison.c
# src/battle_anim_water.c
# src/battle_arena.c
# src/battle_controller_link_opponent.c
# src/battle_controller_link_partner.c
# src/battle_controller_opponent.c
# src/battle_controller_player.c
# src/battle_controller_player_partner.c
# src/battle_controller_recorded_opponent.c
# src/battle_controller_recorded_player.c
# src/battle_controller_safari.c
# src/battle_controller_wally.c
# src/battle_gfx_sfx_util.c
# src/battle_interface.c
# src/battle_main.c
# src/battle_message.c
# src/battle_script_commands.c
# src/battle_util.c
# src/berry.c
# src/data/trainers.h
# src/decompress.c
# src/field_effect.c
# src/hall_of_fame.c
# src/overworld.c
# src/pokeball.c
# src/pokemon.c
# src/pokemon_icon.c
# src/pokemon_storage_system.c
# src/scrcmd.c
2022-08-22 20:30:45 -04:00
Martin Griffin
6fed961ed6
Write palette IDs in hex
2022-08-19 15:29:35 +01:00
Eduardo Quezada
7b3401ee27
Standarized use of star in pointer types
2022-07-29 10:17:58 -04:00
Sneed69
c60de5055d
remove IsMoveWithoutAnimation
2022-06-03 17:42:42 +03:00
ultima-soul
23bf41713c
Merge branch 'master' of github.com:pret/pokeemerald into battle_engine_sync
2021-12-01 20:17:08 -08:00