Nephrite
a8967da1c5
Overheat (and clones)
...
Also, Syrup Bomb (really weird script)
2023-12-24 23:27:21 +09:00
Nephrite
a244d7b8b6
Updated moves that raise the target's own stats
...
To do: moves like CC, Overheat that LOWER stats; did NOT remove the effect for raising all stats due to an AI function
2023-12-24 22:55:53 +09:00
Alex
61e6365470
Fixes Photon Geyeser category + minor AI calc fixes ( #3807 )
2023-12-23 12:31:40 +01:00
Bassoonian
db0a9484ae
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into berryexpansion
2023-12-23 00:39:10 +01:00
kittenchilly
505b8b63eb
Add Doodle + update ability banlists ( #3609 )
...
* Add Doodle
* Doodle test
* Oops
* Update battle_util.c
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-22 16:45:55 +01:00
DizzyEggg
fcdc515be2
Fix rain dance/sunny day not blending opponent sprite ( #3785 )
2023-12-21 13:17:05 +01:00
DizzyEggg
6137db102e
Ally Switch ( #3533 )
...
* ally switch move animation
* Ally Switch anim done
* ally switch test and improve animation
* derp
* add ally switch known failing test for ally targeting moves
* moves which targetted ally fail after ally switch
* ally switch works like protect
---------
Co-authored-by: root <root@LAPTOP-3SNV7DEQ>
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-20 15:26:28 +01:00
Martin Griffin
50cbcebc81
Merge remote-tracking branch 'rhh/master' into upcoming
2023-12-20 12:56:35 +00:00
Alex
1e25b53433
Partner Battle refactor ( #3592 )
...
* Partner Battle refactor
* fix for steven id
* clean up
* Use trainer partner names for id
* removed testing leftover
* comment change
* more review changes
* fix compiling
* remove partener count
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-20 12:38:28 +01:00
Martin Griffin
13a4bf5838
Merge remote-tracking branch 'rhh/master' into upcoming
2023-12-19 18:08:13 +00:00
Zimmermann Gyula
df447c48d3
Realign battleanim array with battlemove array.
2023-12-19 19:03:23 +01:00
Nephrite
4a1a6c5625
Battlemove refactored (recoil, crit and Z moves) ( #3575 )
...
* Unified EFFECT_RECOIL
Combined EFFECT_RECOIL_25/33/50/33_STATUS into a single EFFECT; added an extra field to BattleMove 'secondaryData' that contains the franction of HP recoil; argument still holds status effect for Flare Blitz/Volt Tackle
* BattleMove struct change
Added critrate, recoil, multihit fields, made zMove into a union of effect/powerOverride for status/non-status moves respectively. Added new recoil field and zMove field to all moves. To-do: crit rate, multihit
* Critrate field added
Moves use a critRate field instead of a flag - obsoletes EFFECT_ALWAYS_CRIT
* Just a little define
Makes clear that critBoost = 3 means ALWAYS CRIT
* Added a proper recoil field
Just to make it unambiguous and flexible - can finally have a move with 69% recoil.
* Fixed AI damage calculation for multi-strike moves
* Fixes + removed unused effects
* Tests fixes
Two to fix: pass when run in isolation but not when the whole group is run, which is annoying...
* Minor fixes
* Minor tweaks
* Fixed move effects
* recoil tests
---------
Co-authored-by: Alex <alexthenotes@gmail.com>
2023-12-19 16:10:07 +01:00
DizzyEggg
59a159c338
Fix Ice Face ignoring move effects ( #3755 )
...
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-18 16:02:07 +01:00
DizzyEggg
64f8635496
fix telekinesis not working ( #3763 )
...
* fix telekinesis not working
* typo
* remove one roost known failing
---------
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-18 15:50:03 +01:00
Eduardo Quezada
c505abd53d
Merge branch 'RHH/master' into RHH/upcoming
2023-12-17 18:13:26 -03:00
DizzyEggg
e22ac51617
Fix Innards Out doing dmg after Gastro Acid / vs Magic Guard ( #3758 )
...
* gastro acid stays for fainted mons
* Innards Out does not damage Magic Guard Pokemon
2023-12-17 21:47:12 +01:00
DizzyEggg
acec68fdb8
fix neutralising gas visual glitch ( #3746 )
...
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-17 00:41:50 +01:00
Eduardo Quezada
537f1c9235
Merge branch 'RHH/master' into RHH/upcoming
2023-12-16 20:13:15 -03:00
Alex
e339bc4f29
Fix Fiery Wrath anim ( #3739 )
2023-12-15 20:27:04 +01:00
Bassoonian
0fd08a32ac
Add status form change
2023-12-15 11:17:35 +01:00
Alex
38c61854e6
Changed Ivy Gudgel effect ( #3721 )
...
* Change Ivy Gudgel effect
* test assumptions
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-12-14 18:09:06 +01:00
Eduardo Quezada
b2917fac5d
Merge remote-tracking branch '_RHH_origin/master' into RHH/upcoming
...
# Conflicts:
# include/constants/battle_script_commands.h
# src/battle_script_commands.c
2023-12-10 14:29:42 -03:00
Eduardo Quezada
ce7fe75ac1
Merge branch 'RHH/upcoming' into RHH/pr/upcoming/pret_20231210
...
# Conflicts:
# src/data/pokemon/species_info.h
2023-12-10 13:49:55 -03:00
Eduardo Quezada
1fc712f153
Merge remote-tracking branch '_pret/master' into RHH/pr/upcoming/pret_20231210
...
# Conflicts:
# Makefile
# data/battle_scripts_1.s
# gflib/malloc.c
# gflib/malloc.h
# include/battle.h
# ld_script.ld
# ld_script_modern.ld
# src/battle_ai_script_commands.c
# src/battle_main.c
# src/battle_script_commands.c
# src/battle_util.c
# src/data/pokemon/species_info.h
# src/pokemon.c
2023-12-10 13:27:09 -03:00
Alex
628eb95925
Adds Rage Fist ( #3573 )
...
* Adds Rage Fist
* Fix initial implementation
* fix merge
* review changes
* endure test
* add field enduredDamage
* rage fist: transform, disguise and field change
* merge fix
2023-12-10 12:33:25 +01:00
Alex
403843cecf
Fixes Fling damage calcs ( #3670 )
2023-12-10 00:27:05 +01:00
Alex
d5f3df6f08
Fix Defog and Prevent Escape effects ( #3668 )
...
* Fix Defog and Prevent Escape effects
* pain split / mirror coat interaction
* remove unused various define
* use pain split effect
* remove test
2023-12-10 00:26:03 +01:00
Alex
d86a2136a7
Fixes Cutton Down / Defiant interaction ( #3657 )
2023-12-08 17:29:29 +01:00
Bassoonian
1e0b895ecb
Add missing check to prevents water grinding
2023-12-08 01:05:54 +01:00
Bassoonian
9d09b367a0
Refactor growth time and add six stage toggle
2023-12-07 13:22:01 +01:00
Bassoonian
c8d356a3f1
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into berryexpansion
2023-12-07 12:18:50 +01:00
Bassoonian
8e43b7d696
Debug Berry functions
2023-12-06 21:08:09 +01:00
Patrick Curran
f7ca839f23
EFFECT_CHILLY_RECEPTION ( #3379 )
...
* Chilly Reception Effect
* Wrap Chilling Reception Message Better
* Animation & Some Testing
* Remove Wimp Out cases from Chilly Reception tests
* Animation tweaks
* Battle Script Updates
* Created CheckPrimalWeather macro for Weather Effects
* Updated Chilly Reception logic to switch even if weather doesn't change
Testing Updates
* Fixed test: Move does not animate if weather fails to change
* Remove snow animation check during failure path test
* * Fix indentation
* Move Chilly Reception animation to always play (even when weather change fails)
* Updates to MoveSwitch and PartingShot to get closer to original logic
* Update BattleScript_EffectChillyReception logic
* * Move CHILLY_RECEPTION animation
* Test updates
* Fix Chilly Reception MESSAGE checks
---------
Co-authored-by: Patrick Curran <rapidnutcracker@gmail.com>
Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com>
2023-12-06 17:11:13 +01:00
Bassoonian
3e1c04cc26
Allow pests and weeds interaction
2023-12-05 22:13:21 +01:00
Bassoonian
36befdcdf8
Add moisture clock, weeds and pest generation
2023-12-05 21:54:17 +01:00
Bassoonian
ddcd0dbb78
Weeds and Pests strings
2023-12-05 20:02:11 +01:00
Bassoonian
6da03e6cf0
Add Berry color and drain rate
2023-12-05 02:16:22 +01:00
Bassoonian
0d70d9951d
Put Mulch behind config
2023-12-04 00:33:25 +01:00
Eduardo Quezada
d076193b9f
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# asm/macros/battle_script.inc
# include/constants/battle.h
# include/constants/battle_script_commands.h
# src/battle_script_commands.c
# src/data/battle_moves.h
2023-12-03 16:39:32 -03:00
Bassoonian
45e19d22fa
Remove lost comment
2023-12-03 13:22:58 +01:00
Bassoonian
b02b3d074f
Add Mulch effects
2023-12-03 13:17:34 +01:00
Alex
d1a69d7e04
fix new line ( #3621 )
2023-11-30 20:01:21 -03:00
psf
2b1d36db46
Fix issue where Sky Battles cause upcoming not to compile when debug menu is turned off ( #3617 )
...
* Moved Sky Battle error message outside of debug.inc
https://github.com/rh-hideout/pokeemerald-expansion/issues/3615\#issue-2015546179
* Update data/scripts/debug.inc
Made changes from Jasper's review
625f007741
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
---------
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-11-29 23:08:36 +01:00
Alex
4bde378c0d
Fixes Floral Healing + Tests ( #3604 )
2023-11-29 13:57:29 +01:00
Bassoonian
a517e14c06
Berry Mutations
2023-11-29 13:26:43 +01:00
sbird
ecab5cc106
Merge remote-tracking branch 'pret/master' into feature/dynmulti
2023-11-29 13:06:18 +01:00
ghoulslash
8c4058c7a8
add HITMARKER_DISABLE_ANIMATION for bug bite consumeberry ( #3607 )
...
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2023-11-28 18:57:11 +01:00
Nephrite
460eeff3e5
All moves (I think) that hit and lower a stat
...
Includes Grav Apple - test that checks the AI can see its power bump needs fixing
2023-11-28 16:17:11 +09:00
Nephrite
a1a62f431d
More moves
...
Poison Fang, Knock Off, Thunder, Hurricane, Snore; also Thief, hit_and_escape moves, recharge moves, (but didn't remove effect)
2023-11-28 00:03:42 +09:00
psf
fe16a2cdee
Port pokefirered's Vs. Seeker to pokeemerald ( #3256 )
...
* First version of Vs. Seeker
* Update movement.inc
98f7e9978d (r1306721924)
* Update field_effect_scripts.s
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722004
* Update field_effect_scripts.s
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722024
* Update item_use.h
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722401
* Update movement_action_func_tables.h
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722828
* Update event_object_movement.c
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722887
* Update overworld.c
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306723396
* Update vs_seeker.h
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306724158
* Update vs_seeker.c
Addressed some cleanup comments from SBird
* Update UpdateRandomTrainerRematches
Fixed typo in ClearAllTrainerRematchStates
Fixed types in GetRematchableTrainerLocalId
* Updated UseVsSeekerEffect_2
* Updated UseVsSeekerEffect_3
* Updated UseVsSeekerEffect_4
* Fixed bug that allowed Vs Seeker to be used indoors in correct places
Moved VsSeeker function declarations into header
* Refactored FieldUseFunc_VsSeeker
* Added curly braces to else case in FieldUseFunc_VsSeeker
* renamed data[x] in Task_ResetObjectsRematchWantedState
* Refactored Task_ResetObjectsRematchWantedState
* Refactored VsSeekerResetObjectMovementAfterChargeComplete
* Refactored ResetMovementOfRematchableTrainers
* Refactored GatherNearbyTrainerInfo
* Refactored Task_VsSeeker_3
* CanUseVsSeeker
* Refactored GetVsSeekerResponseInArea
* GetCurVsSeekerResponse refactored
* Cleaned up GetTrainerFlagFromScript
* Gave sensible names to Task_VsSeeker
* Fixed two bugs where player would not have the right gfx state after using VsSeeker on a Bike or Underwater
* Renamed UseVsSeeker Functions
* Added I_VS_SEEKER_CHARGING to make Vs. Seeker broken until flag is assigned
Removed extra VsSeeker animation code
* Addressed PR feedback
* Fixed issue with building non-modern
* Refactored GetRunningBehaviorFromGraphicsId and renamed to GetResponseMovementTypeFromTrainerGraphicsId
* Addresses Lunos's PR feedback: https://github.com/rh-hideout/pokeemerald-expansion/pull/3256\#pullrequestreview-1623547850
Removed the check to see if a map was not indoors to improve readability
Made IsValidLocationForVsSeeker into a static function
* Added changes in response to Jasper's feedback
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256\#pullrequestreview-1725276522
* Updated with Edu's discord feedback https://discord.com/channels/419213663107416084/1135040810082123907/1176872015085453392
* Removed ifdef tags around the repo unless needed
b5dc744ced
2023-11-26 18:58:43 +01:00