DavidJCobb
7ee3043c58
Update battle_controllers.h
...
typo
2025-04-26 11:47:48 -04:00
DavidJCobb
2864408060
Tweaks to documentation comments
2025-04-26 11:40:14 -04:00
DavidJCobb
b4ee45f3e8
Renamed BATTLELINKMSGTYPE_ to BATTLELINKCOMMTYPE_
...
I want to avoid the word "message" since PRET has already chosen "battle message" as the term for predefined strings usable in the battle scripts and UI.
I was considering the term "battle link packet" instead, but the library for wireless communications already uses the word "packet" even though GBATEK does not. I'm going with "battle link communication type" instead. For this particular context, I don't think we need a compound noun ("X type"); the singular noun "type" is fine enough.
2025-04-26 11:37:20 -04:00
DavidJCobb
8f5c1a452d
Update battle_controllers.h
...
Simplified macros.
2025-04-26 01:33:17 -04:00
DavidJCobb
2738d11b0f
Additional fixes to last few commits
...
ROM now compiles, but it's not comparing as equal...
2025-04-26 01:00:16 -04:00
DavidJCobb
a4370ffcde
gBattleControllerExecFlags bits now identified via helper macros
...
Created "exposition" macros to describe operations performed on gBattleControllerExecFlags. Updated the battle engine internals to use them, to more clearly document how battle link communications actually work.
2025-04-26 00:45:03 -04:00
DavidJCobb
9dc48899d3
BUFFER_A/B -> BATTLELINKMSGTYPE; link send/recv. task data names
...
Replaced the BUFFER_A and BUFFER_B constants with the BATTLELINKMSGTYPE enum, which also identifies the "controller becoming idle" message type.
Named the task data for the link send task and the link receive task. Added macros to functions related to those tasks, for legibility.
2025-04-26 00:13:42 -04:00
Alex
71cfab6477
Fixes Magician Life Orb interaction ( #6676 )
2025-04-22 21:01:00 +02:00
Alex
d220459a01
Fixes Intimidate / Eject Pack interaction ( #6645 )
...
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2025-04-21 17:33:29 +02:00
Alex
86969f9919
Remove HitmarkerSwapAttackerTarget ( #6627 )
...
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2025-04-20 22:49:52 +02:00
Eduardo Quezada
c650199909
Added missing gMovesInfo encapsulation ( #6656 )
2025-04-20 22:36:27 +02:00
Alex
6b09480912
Fixes some restore issues ( #6629 )
2025-04-18 16:57:04 -04:00
LOuroboros
cb98106db0
Corrected Dexnav config related comment ( #6610 )
2025-04-13 21:49:38 -04:00
GriffinR
709cfa1c9a
Merge pull request #2014 from Bassoonian/battleterrain
...
Rename battle terrain to environment
2025-04-13 19:32:06 -04:00
Alex
a4bfbea3cb
Revert wrongly done Embody Aspect fix ( #6607 )
2025-04-14 00:17:10 +02:00
Bassoonian
d173e42372
Remove redundant AI defines ( #6590 )
2025-04-13 11:22:14 +02:00
Bassoonian
563e094ea8
Add clarification for EVO_SCRIPT_TRIGGER_DMG ( #6579 )
2025-04-12 12:56:30 -04:00
Bassoonian
708bb4a831
Merge branch 'master' of https://github.com/pret/pokeemerald into pretmerge10apr
2025-04-10 23:57:57 +02:00
hedara90
cf98d764ad
Gimmick Indicator refactor ( #6553 )
...
Co-authored-by: Hedara <hedara90@gmail.com>
2025-04-10 23:56:26 +02:00
cawtds
1672d99060
make linkDirection more robust to member reordering
2025-04-09 13:40:39 +02:00
Alex
edb196e851
Fixes Red Card against Dynamaxed mons ( #6526 )
2025-04-02 14:28:53 +02:00
hedara90
4f0caf8199
Fixes Tera Type not being carried over to during form change / evolution ( #6502 )
2025-04-01 16:52:40 +02:00
Isaac Aronson
74e84da571
Remove NDEBUG guard on cycle counter functions
2025-03-31 13:11:18 -05:00
AlexOn1ine
d767211c4a
helper function to get the species type based on personality
2025-03-31 14:49:40 +02:00
Isaac Aronson
926a7437da
Add AI thinking cycle count display to frame count
2025-03-30 17:24:36 -05:00
Hedara
3615fdde29
START OF 1.11.2 CYCLE
2025-03-30 14:56:39 +02:00
Hedara
e350bea168
Expansion 1.11.1 Release
2025-03-30 14:55:51 +02:00
Alex
23841f6322
Fix hit escape ace mon switching ( #6498 )
2025-03-29 19:34:37 +01:00
Alex
adf4928fe0
Fixes timesGotHit not increasing on forced switch out ( #6493 )
2025-03-29 19:33:50 +01:00
Pawkkie
1c0e5bb0e1
fix hit escape switching
2025-03-29 14:18:20 -04:00
Hedara
a3a48c59b8
Merge remote-tracking branch 'pret/master' into pret-merge-2025-03-29
2025-03-29 14:21:29 +01:00
Alex
79a2ec1ce2
Fixes Emergency Exit and Eject Pack ( #6459 )
2025-03-29 14:04:01 +01:00
hedara90
b0c7d1a8ee
Made memory integrity checks run betweeen PARAMETRIZE runs ( #6462 )
...
Co-authored-by: Hedara <hedara90@gmail.com>
2025-03-28 21:43:04 +01:00
Martin Griffin
71a5542168
metaprogram.h without global.h ( #6469 )
2025-03-28 21:21:58 +01:00
Alex
ce3d6a924a
Fixes clear body type effect and clear amulet against protect effects ( #6482 )
2025-03-28 11:35:06 +01:00
hedara90
a36f838d76
AI gimmick check changed from checking trainer data to a BattleStruct field ( #6478 )
...
Co-authored-by: Hedara <hedara90@gmail.com>
2025-03-25 20:01:34 +01:00
Hedara
521432b269
Renamed a berry tag variable
2025-03-24 13:47:47 +01:00
Alex
b93976c980
Fixes Cheek Pouch mutating damage ( #6466 )
2025-03-23 23:34:24 +01:00
ghoulslash
051adbdce2
Fix DexNav search level ( #6421 )
2025-03-23 11:29:51 -04:00
Alex
5c05715585
Adds move description battle config ( #6364 )
2025-03-20 10:12:37 +01:00
PhallenTree
cf9ee2caee
Fixes Toxic Spikes Absorbed message ( #6448 )
2025-03-19 13:46:23 +01:00
Alex
4193963096
Fixes Cotton Spore failing if one of the targets blocks it ( #6418 )
...
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
Co-authored-by: DizzyEggg <jajkodizzy@wp.pl>
2025-03-18 15:41:37 +01:00
Alex
99a3d01877
Fixes dynamax reversion when ejected out + anim fix ( #6416 )
...
Co-authored-by: hedara90 <90hedara@gmail.com>
2025-03-17 19:57:38 +01:00
PhallenTree
ddab689a07
Fixes Neutralizing Gas Exits, Weather Abilities and Terrain Effects order ( #6435 )
2025-03-16 23:10:20 +01:00
Deokishisu
eaf7549854
Replace Incorrect Slow Stairs Movement with Correct One ( #6275 )
2025-03-16 14:51:36 -07:00
GriffinR
04eb22f4ea
Fix offset for towerInterview in BattleFrontier
2025-03-15 17:45:42 -04:00
cawtds
5aa85e7b8d
fix search level
2025-03-15 00:20:01 +01:00
Alex
3def0e751b
Fixes crash damage move against absorbing abilities ( #6361 )
2025-03-09 20:54:58 +01:00
cawtds
7eaaa1f8d4
remove/replace IsAlly leftovers
2025-03-09 15:05:05 +01:00
PhallenTree
e750dca08a
Reorder Dancer activation
2025-03-04 11:02:33 +00:00
